Skip to content

fix(sitemap): ensure sitemap excludes pages with frontmatter sitemap …#3316

Closed
srgg wants to merge 1 commit into
HugoBlox:mainfrom
srgg:fix/sitemap-ignores-frontmatter-disable
Closed

fix(sitemap): ensure sitemap excludes pages with frontmatter sitemap …#3316
srgg wants to merge 1 commit into
HugoBlox:mainfrom
srgg:fix/sitemap-ignores-frontmatter-disable

Conversation

@srgg
Copy link
Copy Markdown
Contributor

@srgg srgg commented Apr 7, 2026

🚀 What type of change is this?

  • [ x] 🐛 Bug fix (A non-breaking change that fixes an issue)
  • ✨ New feature (A non-breaking change that adds functionality)
  • 💅 Style change (A change that only affects formatting, visuals, or styling)
  • 📚 Documentation update (Changes to documentation only)
  • 🧹 Refactor or chore (A code change that neither fixes a bug nor adds a feature)
  • 💥 Breaking change (A fix or feature that would cause existing functionality to not work as expected)

🎯 What is the purpose of this change?

The sitemap currently includes pages that are explicitly disabled via frontmatter (e.g. sitemap.disable = true).

This behavior is unexpected, as pages marked for exclusion from the sitemap should not appear in the generated sitemap.xml.

The purpose of this change is to update the Hugo Blox sitemap layout so that it correctly respects the sitemap.disable frontmatter flag and excludes those pages from the sitemap.

📸 Screenshots or Screencast (if applicable)

Not applicable.

Example frontmatter:

sitemap:
  disable: true

ℹ️ Documentation Check

  • [ x] No, this change does not require a documentation update.
  • Yes, I have updated the documentation accordingly (or will in a follow-up PR).

📜 Contributor Agreement

Thank you for your contribution!

@srgg srgg requested a review from gcushen as a code owner April 7, 2026 19:00
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 7, 2026 •
edited
Loading

✅ Deploy Preview for academic-demo canceled.

Name Link
🔨 Latest commit f45046e
🔍 Latest deploy log https://app.netlify.com/projects/academic-demo/deploys/69d55455a63bc40008b2821b

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Wow, your first PR! Welcome to the community! 🎉

Thank you for this contribution to open source and open research. It makes a huge impact for the thousands of innovators building with Hugo Blox.

If you're wondering about next steps, please read our Contributor Guide for coding standards, how to run the project locally, and how to get help.

We hope this is just the start of your journey with us. Let's build the future together! Join us on Discord to connect with the team and community.

Awesome work, we'll take a look soon! ✨

@gcushen
Copy link
Copy Markdown
Collaborator

gcushen commented Apr 8, 2026

Thanks for the PRs and for identifying that private pages can leak into the RSS feed - that's a real gap we'll fix.

However, HugoBlox uses its own private: true frontmatter param (rather than Hugo's newly added sitemap.disable inspired by private) to control page visibility across all surfaces (sitemap, RSS, 404 suggestions, search engine indexing). This is by design - it's a simpler, flatter param that's more intuitive for our audience.

We'll fix the RSS feed to respect private (which was missing). Supporting Hugo's suggested sitemap.disable as an additional mechanism would be a new feature rather than a bug fix, and we'd want to evaluate that separately as that would add unnecessary bloat and confusion for our community.

@gcushen gcushen closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcushen gcushen Awaiting requested review from gcushen gcushen is a code owner

Assignees

No one assigned

Labels

modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srgg @gcushen